Wireshark-commits: [Wireshark-commits] master 1fcb321: nettrace: fix potential buffer overflow in t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Jan 2019 16:38:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1fcb32148702766e13dba0e8691e8b2a8b9d1f2f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1fcb321 by Peter Wu (peter@xxxxxxxxxxxxx):

    nettrace: fix potential buffer overflow in time parsing
    
    sscanf can consume less than 19 characters (e.g. given time format
    1-1-1T1:1:1), be sure to reject such input. Fix some dead store warning
    while at it.
    
    Change-Id: I6148599048f1e89ea7aafdbdd6450574a97b22fd
    Fixes: v2.9.1rc0-372-gd38f6025b0 ("nettrace: Handle beginTime with fractions of seconds.")
    Reviewed-on: https://code.wireshark.org/review/31699
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ccf37e3   CMake: fix failure to locate zlib (and possibly libssh)
     add  1fcb321   nettrace: fix potential buffer overflow in time parsing


Summary of changes:
 wiretap/nettrace_3gpp_32_423.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)