Wireshark-commits: [Wireshark-commits] master 7acb5ca: QUIC: remove gQUIC Q044 support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Jan 2019 12:29:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7acb5caa9f68ff0eafd6086368b07678c3e4ef6a
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7acb5ca by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: remove gQUIC Q044 support
    
    While gQUIC Q044 is compatible with the IETF QUIC long headers format,
    it is not the same. Remove gQUIC support since it is incomplete (flag
    dissection is wrong, payload is not correctly dissected) and slows down
    IETF QUIC dissector development. If support is restored, it should
    likely be added as heuristics in packet-gquic.c
    
    This is a manual revert of v2.9.0rc0-2173-g9fcb4af6b6 ("QUIC: gQUIC Q044
    always use CHLO from gQUIC (with tag)") plus some other changes.
    
    Change-Id: If75d81a4c38475f4e11fd8ade7252991f0ba0316
    Reviewed-on: https://code.wireshark.org/review/31640
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  588c10a   QUIC: remove unused version argument from cipher creation functions
     add  7acb5ca   QUIC: remove gQUIC Q044 support


Summary of changes:
 epan/dissectors/CMakeLists.txt |  1 -
 epan/dissectors/packet-gquic.c | 39 ---------------------------------------
 epan/dissectors/packet-gquic.h | 31 -------------------------------
 epan/dissectors/packet-quic.c  | 15 +++------------
 4 files changed, 3 insertions(+), 83 deletions(-)
 delete mode 100644 epan/dissectors/packet-gquic.h