Wireshark-commits: [Wireshark-commits] master bfcb3cb: QUIC: update for changes in the short header
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Jan 2019 12:29:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfcb3cb522004f6457b7293741874a1c18ef1f48
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bfcb3cb by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: update for changes in the short header flag (draft -17)
    
    Draft -17 shifts the key phase bit and encrypts it. The old KP bit is
    now always 1 which broke decryption due to selection of the wrong
    payload protection cipher.
    
    Split calculation of the header protection and payload protection
    cipher such that the short header flag can be decrypted earlier. Now the
    decrypted flag can be displayed and the correct pp cipher is selected.
    
    Bug: 13881
    Change-Id: Ic9468498c3d0fb3f0a456d947824b40709db4927
    Reviewed-on: https://code.wireshark.org/review/31637
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  a37388f   CMake: Remove unnecessary check for CMAKE_INSTALL_RPATH
     add  bfcb3cb   QUIC: update for changes in the short header flag (draft -17)


Summary of changes:
 epan/dissectors/packet-quic.c | 70 ++++++++++++++++++++++++++++++++-----------
 1 file changed, 52 insertions(+), 18 deletions(-)