Wireshark · Wireshark-commits: [Wireshark-commits] master e953785: QUIC: fix packet number spaces and verification (draft -17)

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e953785dd29e6f20efb1c1081641e2850e8486f5
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e953785 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix packet number spaces and verification (draft -17)
    
    Decryption would fail after switching from Initial to the Handshake
    message due to the packet number changing from 1 to 0 which would result
    in the wrong reconstructed packet number. To fix this, implement three
    different packet spaces and update the full packet number only if
    decryption succeeds.
    
    While at it, document all tricky interactions between packet number
    spaces and different secrets / ciphers.
    
    Bug: 13881
    Change-Id: Ic88a83cdf76cb024054de8a32ea959bd1dacaca3
    Reviewed-on: https://code.wireshark.org/review/31635
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  e400b78   QUIC: fix handshake decryption (draft -17)
     add  e953785   QUIC: fix packet number spaces and verification (draft -17)


Summary of changes:
 epan/dissectors/packet-quic.c | 168 ++++++++++++++++++++++++------------------
 1 file changed, 96 insertions(+), 72 deletions(-)