Wireshark · Wireshark-commits: [Wireshark-commits] master a399187: CMake: Replace PACKAGELIST magic

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a3991874eb3d470a4adfcdef7903ab8d6dd8f881
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a399187 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: Replace PACKAGELIST magic
    
    This is more explicit and easier to read with slightly better locality
    while using less code.
    
    Also less awkward when the package doesn't fit the narrow package list
    expectations.
    
    The ws_find_package() macro doesn't include all the status messages. The
    choice was to rely on standard find_package() and feature_summary() output
    and be less verbose.
    
    Avoid polluting the CLI build interface. Per target include paths and
    macro definitions are preferred.
    
    Because this patch intentionally removes the global CMAKE_*_FLAGS
    and include_directories() usage in favor of target properties, some
    untested build configurations may inadvertently break because of
    missing ${PACKAGE}_INCLUDE_DIRS or ${PACKAGE}_DEFINITIONS. This
    required a manual review of dependencies that might have been
    incomplete.
    
    ${PACKAGE_VAR}_LINK_FLAGS seems to be unused.
    
    Changing the CMake Qt code to use more modern CMake component syntax
    is left as future work.
    
    Change-Id: I3ed75252189a6e05a23ed6e619088f519cd7ed78
    Reviewed-on: https://code.wireshark.org/review/31496
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  be103a4   [Automatic update for 2019-01-20]
     add  a399187   CMake: Replace PACKAGELIST magic


Summary of changes:
 CMakeLists.txt          | 356 ++++++++++++++----------------------------------
 capchild/CMakeLists.txt |   2 +
 caputils/CMakeLists.txt |  12 +-
 cmakeconfig.h.in        |   5 +-
 codecs/CMakeLists.txt   |   7 +
 epan/CMakeLists.txt     |  30 +++-
 extcap/CMakeLists.txt   |  12 +-
 ui/CMakeLists.txt       |   7 +
 ui/qt/CMakeLists.txt    |  14 ++
 wiretap/CMakeLists.txt  |  11 +-
 wsutil/CMakeLists.txt   |   8 ++
 11 files changed, 192 insertions(+), 272 deletions(-)