Wireshark-commits: [Wireshark-commits] master-2.6 433dee0: diam_dict.l, wimaxasncp_dict.l: fix -Wer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 19 Jan 2019 10:34:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=433dee06b1f94e690b06dd3c09e557988f6f984b
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

433dee0 by Peter Wu (peter@xxxxxxxxxxxxx):

    diam_dict.l,wimaxasncp_dict.l: fix -Werror=stringop-truncation
    
    The given "len" is the size of the string in "txt" excluding the NUL
    terminator. GCC 8.2.1+20181127-1 rightfully complains that strncpy will
    not terminate the destination buffer.
    
    Change-Id: I592c7c218cf07c13697de4e60f454326a93d1124
    Reviewed-on: https://code.wireshark.org/review/31600
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 5eb8edf1cbda6a2eea1aa7c101224f859bf31543)
    Reviewed-on: https://code.wireshark.org/review/31603
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  94ac35f   gitlab-ci: keep artifacts in rpm builds.
     add  433dee0   diam_dict.l,wimaxasncp_dict.l: fix -Werror=stringop-truncation


Summary of changes:
 epan/diam_dict.l                          | 4 ++--
 plugins/epan/wimaxasncp/wimaxasncp_dict.l | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)