Wireshark · Wireshark-commits: [Wireshark-commits] master 9565119: dissectors: socketcan: Pass raw ids to dissectors

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9565119d6e46251aef8ec06dde140b77a96b634b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9565119 by Maksim Salau (maksim.salau@xxxxxxxxx):

    dissectors: socketcan: Pass raw ids to dissectors
    
    In the current implementation only masked id is provided to
    subdissectors, which doesn't allow to filter packets effectively.
    E.g.: J1939 should dissect only extended frames. Without EFF flag, the
    subdissector is unable to filter out frames with 11-bit ids.
    Also J1939 tries to dissect pyaload of RTR of ERR frames, which obviously
    doesn't make sense.
    
    The change exports raw id alongside the masked one for backwards
    compatibility. Once all the CAN dissectors are updated to use the raw
    variant (if necessary) the masked variant may be dropped.
    
    Change-Id: I52df5673ecfd53d2e65790c4187ea129e67a88e9
    Reviewed-on: https://code.wireshark.org/review/31448
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d50bd39   Qt: Cleanup deletion of CopyFromProfileMenu
     add  9565119   dissectors: socketcan: Pass raw ids to dissectors


Summary of changes:
 epan/dissectors/packet-socketcan.c | 12 ++----------
 epan/dissectors/packet-socketcan.h | 11 +++++++++++
 2 files changed, 13 insertions(+), 10 deletions(-)