Wireshark-commits: [Wireshark-commits] master fd4d41f: CMake: remove LocatePythonExecutable.cmake f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 Jan 2019 04:22:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd4d41fc329ca33663e0aa12fbccae14fbe9e3fd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fd4d41f by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: remove LocatePythonExecutable.cmake for Windows
    
    Cygwin is now unsupported, so remove special handling for it and rely on
    FindPythonInterp.cmake to locate an appropriate version.
    
    This patch can only cause issues if the PATH environment variable
    contains the Cygwin binary directory without any native Python version
    appearing before that. In that case, either remove Cygwin from PATH or
    add the native Python (e.g. C:\Python37) earlier in PATH.
    
    Change-Id: Ia5554e5a83d06a941dacf4a28d41d84fca4fe99d
    Reviewed-on: https://code.wireshark.org/review/31453
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  aac30ba   CMake,WSDG: Remove Cygwin support
     add  fd4d41f   CMake: remove LocatePythonExecutable.cmake for Windows


Summary of changes:
 CMakeLists.txt                             |  3 ---
 cmake/modules/LocatePythonExecutable.cmake | 22 ----------------------
 2 files changed, 25 deletions(-)
 delete mode 100644 cmake/modules/LocatePythonExecutable.cmake