Wireshark-commits: [Wireshark-commits] master 546cb25: Qt: Fix copy ASCII characters from ByteView
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 08 Jan 2019 16:21:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=546cb252568f712525a7e892bffd6d05c40ff028
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

546cb25 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix copy ASCII characters from ByteView
    
    Only copy ASCII characters when doing "Copy Bytes as Hex + ASCII Dump"
    from the ByteView. This is what we do in all other Hex Dumps.
    
    Also change the parameter name to reflect this.
    
    Change-Id: I63cc79ffa014fd9aa50c84d765ee168f0b1ea44a
    Reviewed-on: https://code.wireshark.org/review/31442
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  ea001cd   mas5gs: Fix dissection of QoS flow descriptions and QoS rules.
     add  546cb25   Qt: Fix copy ASCII characters from ByteView


Summary of changes:
 ui/qt/utils/data_printer.cpp | 13 +++++++------
 ui/qt/utils/data_printer.h   |  2 +-
 2 files changed, 8 insertions(+), 7 deletions(-)