Wireshark-commits: [Wireshark-commits] master 3c372c7: Qt: Add syntax line edit feedback symbols.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 08 Jan 2019 04:48:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c372c7bac98d34d0342837007f3b86c3cba8ff8
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3c372c7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add syntax line edit feedback symbols.
    
    Draw a circle+backslash or a warning triangle in the far right of the
    line edit entry for invalid and deprecated filters respectively. This
    should provide an additional clue for color blind users.
    
    Bug: 15326
    Change-Id: I55a1e214834a340ccda3bfe8880bba12c5e274e9
    Reviewed-on: https://code.wireshark.org/review/30936
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5d30fb5   CIP Safety: Correct Safety Configuration ID
     add  3c372c7   Qt: Add syntax line edit feedback symbols.


Summary of changes:
 image/stock_icons.qrc                              |   4 +
 image/stock_icons/14x14/x-filter-deprecated.png    | Bin 0 -> 316 bytes
 image/stock_icons/14x14/x-filter-deprecated.svg    |  99 +++++++++++++++++++++
 image/stock_icons/14x14/x-filter-deprecated@xxxxxx | Bin 0 -> 402 bytes
 image/stock_icons/14x14/x-filter-invalid.png       | Bin 0 -> 211 bytes
 image/stock_icons/14x14/x-filter-invalid.svg       |  89 ++++++++++++++++++
 image/stock_icons/14x14/x-filter-invalid@xxxxxx    | Bin 0 -> 445 bytes
 image/stock_icons/svg-to-png.sh                    |   4 +-
 ui/qt/main_window.cpp                              |   2 -
 ui/qt/widgets/capture_filter_edit.cpp              |   2 +
 ui/qt/widgets/display_filter_edit.cpp              |  11 ++-
 ui/qt/widgets/display_filter_edit.h                |   1 -
 ui/qt/widgets/syntax_line_edit.cpp                 |  51 ++++++++++-
 ui/qt/widgets/syntax_line_edit.h                   |   1 +
 14 files changed, 253 insertions(+), 11 deletions(-)
 create mode 100644 image/stock_icons/14x14/x-filter-deprecated.png
 create mode 100644 image/stock_icons/14x14/x-filter-deprecated.svg
 create mode 100644 image/stock_icons/14x14/x-filter-deprecated@xxxxxx
 create mode 100644 image/stock_icons/14x14/x-filter-invalid.png
 create mode 100644 image/stock_icons/14x14/x-filter-invalid.svg
 create mode 100644 image/stock_icons/14x14/x-filter-invalid@xxxxxx