Wireshark-commits: [Wireshark-commits] master 0168b71: Require that dissect_atm_pw_oam_cell() be ca
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 06 Jan 2019 19:43:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0168b71cfd6517baf7062b2fc61114f3d49b2299
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0168b71 by Guy Harris (guy@xxxxxxxxxxxx):

    Require that dissect_atm_pw_oam_cell() be called with a non-null data pointer.
    
    The only place where it's currently called passes it data.
    
    Do a DISSECTOR_ASSERT() check to make sure it's non-null.
    
    Remove null-pointer checks that this renders no longer necessary.
    
    Change-Id: I2fc86f9591a7126d328029379ecfe98400dd01cb
    Reviewed-on: https://code.wireshark.org/review/31419
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ffb3328   cdma2k: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
     add  0168b71   Require that dissect_atm_pw_oam_cell() be called with a non-null data pointer.


Summary of changes:
 epan/dissectors/packet-atm.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)