Wireshark-commits: [Wireshark-commits] master de71f0e: No need to check whether atm_info is null in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 06 Jan 2019 19:06:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de71f0e16da046187ce5990b2c6a0098af6d4817
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

de71f0e by Guy Harris (guy@xxxxxxxxxxxx):

    No need to check whether atm_info is null in that code path.
    
    All exported (via dissector tables and dissector handles) routines that
    call dissect_atm_common() first do DISSECTOR_ASSERT(atm_info != NULL),
    so dissect_atm_common() will never be called iwth a null data pointer.
    dissect_reassembled_pdu() is called only from dissect_atm_common(), so
    it also won't ever be called with a non-null data pointer.
    
    Fixes Coverity CID 1442299.
    
    Change-Id: I3b455ac546a6a0cd6aa8ef184c71fda2ca2a0710
    Reviewed-on: https://code.wireshark.org/review/31418
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6f67da9   pgsql: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
     add  de71f0e   No need to check whether atm_info is null in that code path.


Summary of changes:
 epan/dissectors/packet-atm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)