Wireshark · Wireshark-commits: [Wireshark-commits] master 6c5da28: test: split SubprocessTestCase.run into setUp/tearDown

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c5da2804b00ae28b4837f56fa38671753ac64f8
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6c5da28 by Peter Wu (peter@xxxxxxxxxxxxx):

    test: split SubprocessTestCase.run into setUp/tearDown
    
    The run method is not invoked when running in debug mode (for example,
    with `pytest --pdb`) and would result in spurious errors due to "log_fd"
    being None. Split the method to resolve this incompatibility.
    
    Note that with `pytest --pdb`, the tearDown method is not called when
    exceptions occur, see https://docs.pytest.org/en/latest/unittest.html
    
    Change-Id: I4b66c03d5b050b53311ec64021fe17dc91bb48dd
    Reviewed-on: https://code.wireshark.org/review/31339
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  da4aea6   Remove a no-longer-needed DIAG_OFF/DIAG_ON pair.
     add  6c5da28   test: split SubprocessTestCase.run into setUp/tearDown


Summary of changes:
 test/subprocesstest.py | 69 +++++++++++++++++++++++---------------------------
 1 file changed, 31 insertions(+), 38 deletions(-)