Wireshark-commits: [Wireshark-commits] master-2.6 526d852: Windows: use lua-unicode as built with V
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=526d85292e473ffb6be29a2f8d3ecadd6e0d5d7f
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark
Commits:
526d852 by Peter Wu (peter@xxxxxxxxxxxxx):
Windows: use lua-unicode as built with VS 2017
These binaries were built by AppVeyor using VS 2017 (MSVC 19.16.27025.1)
and replaces locally built binaries using VS 2015 (MSVC 19.0.24215.1).
I believe that these are the same as both of them use VCRUNTIME140.dll
and import the same symbols. Using a newer compiler should however
remove any doubt of compatibility with VS 2017 and should address
concerns from Anders and Graham.
These files are actually the "msvc2017_*.zip" files from
https://github.com/Lekensteyn/lua-unicode/releases/tag/5.2.4-release1
Change-Id: Ib3fdf4678267fa10c0729f98ae0ce3153ac278a4
Reviewed-on: https://code.wireshark.org/review/31307
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 7c04036e7218cc73a059dd0f308382fda54d2a8a)
Reviewed-on: https://code.wireshark.org/review/31325
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from 2b2eea1 6lowpan: don't try to use (new) TVB that wasn't created.
add 526d852 Windows: use lua-unicode as built with VS 2017
Summary of changes:
tools/win-setup.ps1 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
