Wireshark-commits: [Wireshark-commits] master e307c70: Make dissect_icmp_extension_structure into a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 02 Jan 2019 08:28:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e307c703fb5eef509123aa9b7bd035a511e202b9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e307c70 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make dissect_icmp_extension_structure into a dissector function.
    
    That way there isn't a need for packet-icmp-int.h.
    
    Change-Id: Ib523c36ab2fdf6a43ee6ff32dadfcd53e9d9bf14
    Reviewed-on: https://code.wireshark.org/review/31290
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ee23110   dpaux: Minor improvements
     add  e307c70   Make dissect_icmp_extension_structure into a dissector function.


Summary of changes:
 epan/dissectors/packet-icmp-int.h | 16 ----------------
 epan/dissectors/packet-icmp.c     | 12 ++++++++----
 epan/dissectors/packet-icmpv6.c   |  7 +++++--
 3 files changed, 13 insertions(+), 22 deletions(-)
 delete mode 100644 epan/dissectors/packet-icmp-int.h