Wireshark-commits: [Wireshark-commits] master 8059bad: No need to report "some files could not be s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 01 Jan 2019 23:12:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8059bad284b6e1cff0db14582f74ab8f5cbe121c
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8059bad by Guy Harris (guy@xxxxxxxxxxxx):

    No need to report "some files could not be saved".
    
    We've already reported the files that couldn't be saved; no need to tell
    the user something they already know by that point.
    
    Change-Id: I8251a46134342df6b40a6324aa76a5237fde7c93
    Reviewed-on: https://code.wireshark.org/review/31298
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  caa2c0a   lorawan: fix this condition has identical branches [-Wduplicated-branches]
     add  8059bad   No need to report "some files could not be saved".


Summary of changes:
 ui/cli/tap-exportobject.c             |  8 +-------
 ui/export_object_ui.c                 | 14 +++++---------
 ui/export_object_ui.h                 |  2 +-
 ui/qt/export_object_dialog.cpp        | 10 +---------
 ui/qt/models/export_objects_model.cpp | 10 +++-------
 ui/qt/models/export_objects_model.h   |  2 +-
 6 files changed, 12 insertions(+), 34 deletions(-)