Wireshark · Wireshark-commits: [Wireshark-commits] master e12270a: Limit the maximum *file* name length for exported objects.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e12270a730a60636ad36c06957b7e1f687c562a7
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e12270a by Guy Harris (guy@xxxxxxxxxxxx):

    Limit the maximum *file* name length for exported objects.
    
    Limiting the maximum *path* name length is bogus; if the user wants to
    store the file in some directory deep under the root (UN*X) or the root
    of the drive (Windows), that's their choice - don't prevent them from
    saving in a directory with a path longer than some maximum or limit the
    file name based on the length of the path leading up to it.
    
    Limiting the maximum *file* name is presumably to cope with, for
    example, HTTP objects with a URL that had a very long query component,
    so it makes sense.
    
    Change-Id: Idfc7de8124ee80bdd4950341ff2239834eb9f6f6
    Reviewed-on: https://code.wireshark.org/review/31295
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bac10e5   Get rid of local_eo_save_entry().
     add  e12270a   Limit the maximum *file* name length for exported objects.


Summary of changes:
 epan/export_object.h                  |  4 +++
 ui/cli/tap-exportobject.c             | 54 ++++++++++++++++-------------------
 ui/qt/export_object_dialog.cpp        |  4 +--
 ui/qt/models/export_objects_model.cpp |  6 ++--
 4 files changed, 33 insertions(+), 35 deletions(-)