Wireshark · Wireshark-commits: [Wireshark-commits] master 2f25e04: krb5: fix parsing of PA-S4U-X509-USER in AS-REQ

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f25e04e00c7ebe895a349b392752e6290952459
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2f25e04 by Isaac Boukris (iboukris@xxxxxxxxx):

    krb5: fix parsing of PA-S4U-X509-USER in AS-REQ
    
    Per [MS-SFU] 2.2.2 PA_S4U_X509_USER in AS-REQ consists of
    the certificate data instead of the corresponding struct.
    
    Also, the subject-certificate field in the struct consists
    of the certificate data as well, so let's decode it as such.
    
    Change-Id: I6f03a66eac74b7d42c0893f63cab772d8ddcb803
    Signed-off-by: Isaac Boukris <iboukris@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/31279
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2d41b15   Add a "failed" return for tap packet routines.
     add  2f25e04   krb5: fix parsing of PA-S4U-X509-USER in AS-REQ


Summary of changes:
 epan/dissectors/asn1/kerberos/kerberos.cnf         |  25 +++--
 .../asn1/kerberos/packet-kerberos-template.c       |  10 +-
 epan/dissectors/packet-kerberos.c                  | 103 ++++++++++++---------
 3 files changed, 83 insertions(+), 55 deletions(-)