Wireshark-commits: [Wireshark-commits] master ba589a4: Move some command-line-oriented routines fro
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 01 Jan 2019 02:07:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba589a4e445a8ad8054073eff846087fc61c9ef8
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ba589a4 by Guy Harris (guy@xxxxxxxxxxxx):

    Move some command-line-oriented routines from wsutil to ui.
    
    cmdarg_err() is for reporting errors for command-line programs and
    command-line errors in GUI programs; it's not something for any of the
    Wireshark libraries to use.
    
    The various routines for parsing numerical command-line arguments are
    not for general use, they're just for use when parsing arguments.
    
    Change-Id: I100bd4a55ab8ee4497f41d9651b0c5670e6c1e7f
    Reviewed-on: https://code.wireshark.org/review/31281
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5a5d236   Add some new symbols.
     add  ba589a4   Move some command-line-oriented routines from wsutil to ui.


Summary of changes:
 capinfos.c                     |  2 +-
 capture_opts.c                 |  4 ++--
 captype.c                      |  2 +-
 debian/libwsutil0.symbols      |  8 --------
 dumpcap.c                      |  4 ++--
 editcap.c                      |  4 ++--
 extcap/androiddump.c           |  2 +-
 fuzz/CMakeLists.txt            |  1 +
 fuzz/fuzzshark.c               |  2 +-
 mergecap.c                     |  4 ++--
 randpkt.c                      |  4 ++--
 rawshark.c                     |  4 ++--
 reordercap.c                   |  2 +-
 sharkd.c                       |  4 ++--
 tfshark.c                      |  4 ++--
 tshark.c                       |  4 ++--
 ui/CMakeLists.txt              |  2 ++
 ui/cli/tap-camelsrt.c          |  2 +-
 ui/cli/tap-diameter-avp.c      |  2 +-
 ui/cli/tap-endpoints.c         |  2 +-
 ui/cli/tap-exportobject.c      |  2 +-
 ui/cli/tap-hosts.c             |  2 +-
 ui/cli/tap-httpstat.c          |  2 +-
 ui/cli/tap-icmpstat.c          |  2 +-
 ui/cli/tap-icmpv6stat.c        |  2 +-
 ui/cli/tap-iousers.c           |  2 +-
 ui/cli/tap-protocolinfo.c      |  2 +-
 ui/cli/tap-protohierstat.c     |  2 +-
 ui/cli/tap-rpcprogs.c          |  2 +-
 ui/cli/tap-rtd.c               |  2 +-
 ui/cli/tap-rtspstat.c          |  2 +-
 ui/cli/tap-sctpchunkstat.c     |  2 +-
 ui/cli/tap-simple_stattable.c  |  2 +-
 ui/cli/tap-sipstat.c           |  2 +-
 ui/cli/tap-smbsids.c           |  2 +-
 ui/cli/tap-srt.c               |  2 +-
 ui/cli/tap-sv.c                |  2 +-
 ui/cli/tap-wspstat.c           |  2 +-
 {wsutil => ui}/clopts_common.c |  4 ++--
 {wsutil => ui}/clopts_common.h | 18 ++++++++----------
 {wsutil => ui}/cmdarg_err.c    |  3 +--
 {wsutil => ui}/cmdarg_err.h    | 14 ++++++--------
 ui/commandline.c               |  4 ++--
 ui/decode_as_utils.c           |  2 +-
 ui/dissect_opts.c              |  4 ++--
 ui/failure_message.c           |  2 +-
 ui/qt/main.cpp                 |  4 ++--
 wsutil/CMakeLists.txt          |  4 ----
 48 files changed, 72 insertions(+), 86 deletions(-)
 rename {wsutil => ui}/clopts_common.c (97%)
 rename {wsutil => ui}/clopts_common.h (72%)
 rename {wsutil => ui}/cmdarg_err.c (97%)
 rename {wsutil => ui}/cmdarg_err.h (81%)