Wireshark · Wireshark-commits: [Wireshark-commits] master 7b0eee5: Improve capture-on-pipe error messages.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b0eee5bc53b445851f52180f3657209e50422ea
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7b0eee5 by Guy Harris (guy@xxxxxxxxxxxx):

    Improve capture-on-pipe error messages.
    
    Add "Please report this to us" and "Please report this to whoever wrote
    the program that's writing to the pipe" secondary error messages.  Use
    the latter for most of the errors, as the most likely cause is that the
    program writing to the pipe is messing up somehow.
    
    If we don't recoginze the first 4 bytes of the file, say "Data written
    to the pipe is neither in a supported pcap format nor in pcapng
    format." - it's not necessarily a pcap file.
    
    Speak of "pcap" rather than "libpcap" format - it's not completely tied
    to libpcap (although two of the libraries not called "libpcap" that read
    it are basically libpcap+a Windows driver+a library for the Windows
    driver, at this point), and the suffix generally used it ".pcap".
    
    Change-Id: Ifb5518af5cade788294c93a7ac416893f57f6bc8
    Reviewed-on: https://code.wireshark.org/review/31273
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ba32436   WSDG: Update packet list and popup images and descriptions.
     add  7b0eee5   Improve capture-on-pipe error messages.


Summary of changes:
 dumpcap.c | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)