Wireshark · Wireshark-commits: [Wireshark-commits] master 6b7c735: Qt: traffic table: remove a tap listener only once

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b7c73580ba765a914f5f05873f656df03ab8c4b
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6b7c735 by Martin Kaiser (wireshark@xxxxxxxxx):

    Qt: traffic table: remove a tap listener only once
    
    Class TrafficTableTreeWidget is used by the conversation and enpoint
    dialogs, both of which are subclasses of WiresharkDialog.
    
    Those dialogs use WiresharkDialog::registerTapListener() to register tap
    listeners. When the dialog is closed, those listeners are removed by
    WiresharkDialog::removeTapListeners().
    
    TrafficTableTreeWidget's destructor tries to remove its tap listener a
    2nd time after WiresharkDialog did its cleanup. This causes warnings
    
    Warn remove_tap_listener(): no listener found with that tap data
    
    Don't call remove_tap_listener() from TrafficTableTreeWidget's
    destructor. The destructor is now empty and can be removed completely.
    
    Change-Id: I3143fa1c5116203f4a0be791bd4c5f08135aefb0
    Reviewed-on: https://code.wireshark.org/review/31259
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  932edd0   CMake: clean up FindGCRYPT.cmake
     add  6b7c735   Qt: traffic table: remove a tap listener only once


Summary of changes:
 ui/qt/traffic_table_dialog.cpp | 5 -----
 ui/qt/traffic_table_dialog.h   | 1 -
 2 files changed, 6 deletions(-)