Wireshark-commits: [Wireshark-commits] master ffbd46c: DNS: Use microsecond resolution for request/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Dec 2018 22:41:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ffbd46ce7b3edc804cd4810b7a74ec1a46c93288
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ffbd46c by Michael Mann (mmann78@xxxxxxxxxxxx):

    DNS: Use microsecond resolution for request/response statistics.
    
    The stat tree API only supports 32-bit integers and if nanosecond resolution
    is used correctly it's easy to hit integer overflow issues on even a fairly
    small capture file trying to sum up response times.
    
    Bug: 15382
    Change-Id: I15d2cfbdbec7b0bef2bcfe1afe4f6eb6fc1d2456
    Reviewed-on: https://code.wireshark.org/review/31217
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  eb8c996   ebhscr: fixing WTAP_ENCAP_EBHSCR
     add  ffbd46c   DNS: Use microsecond resolution for request/response statistics.


Summary of changes:
 epan/dissectors/packet-dns.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)