Wireshark-commits: [Wireshark-commits] master 2d57a56: Qt: switch about#wireshark label to QTextBro
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Dec 2018 08:32:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d57a56fa6939d3b14517937a9def1c19f18fe21
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2d57a56 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: switch about#wireshark label to QTextBrowser.
    
    QTextEdit supports the scrollbar. The drawback of having a scrollbar
    is that we need to remove the space (on the right, at least). This change
    switches from QLabel to QTextBrowser and removes the empty spaces and the
    horizontal layout (not needed anymore). The resulting look is a mix
    from the Authors tab and original look.
    
    While on it, the default height has been increased to make room for the full
    message (not needing the scrollbar with the defualt message) and the link
    to the wireshark site has been made clickable.
    
    Bug: 15375
    Change-Id: Id0a10f366c0797c98264d3a1cad58a4dc11467e3
    Reviewed-on: https://code.wireshark.org/review/31153
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4f557ea   Qt: Switch line edits to new-style signals and slots.
     add  2d57a56   Qt: switch about#wireshark label to QTextBrowser.


Summary of changes:
 ui/qt/about_dialog.cpp |  8 ++++--
 ui/qt/about_dialog.ui  | 74 ++++++++++++--------------------------------------
 2 files changed, 23 insertions(+), 59 deletions(-)