Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 516be16: Qt: Open our preference dialogs via "clicked" signals.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=516be16a35d7e2cc29ddfbac1d74cf6da4487b5e
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

516be16 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Open our preference dialogs via "clicked" signals.
    
    In ModulePreferencesScrollArea we create QPushButtons that open modal
    UAT and file dialogs. Open them via the "clicked" signal instead of
    the "pressed" signal. "clicked" is a general activation signal that
    fires after the mouse button has been clicked+released or a keyboard
    event. "pressed" fires before "released" and can be problematic in
    some cases.
    
    Bug: 15366
    Change-Id: Icb353d86ae0a4b4b97e5f63df791ec562070756d
    Reviewed-on: https://code.wireshark.org/review/31125
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a2970e0   Lua: Fix compilation with Lua 5.1.
     add  516be16   Qt: Open our preference dialogs via "clicked" signals.


Summary of changes:
 ui/qt/module_preferences_scroll_area.cpp | 16 ++++++++--------
 ui/qt/module_preferences_scroll_area.h   |  8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)