Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 29e5315: Clean up exp_pdu_open() API.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29e5315c58bc45ba9dab462d86f8af51057c3a86
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

29e5315 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up exp_pdu_open() API.
    
    It really shouldn't free the comment passed to it, as the caller
    allocated it, and knows how to free it if necessary; it might not even
    have been allocated.
    
    Make the comment argument a "const char *" to 1) allow passing string
    constants etc. and 2) to catch any attempts to free it in
    exp_pdu_open().
    
    Make the callers free it after exp_pdu_open() returns.
    
    (Alternatively, we could have exp_pdu_open() take the file name argument
    and generate the comment itself, so that all code paths generate the
    same comment.)
    
    Change-Id: I6e6924b05565761b641a6c3b4d9a2e97f4264e1b
    Ping-Bug: 15365
    Reviewed-on: https://code.wireshark.org/review/31105
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 936f3ed6baf7bcc5891ad8dbbcf7a213a264d20d)
    Reviewed-on: https://code.wireshark.org/review/31106
    

Actions performed:

    from  d0c1069   Always set *dfp to NULL on an error return from dfilter_compile().
     add  29e5315   Clean up exp_pdu_open() API.


Summary of changes:
 tshark.c                 | 2 +-
 ui/export_pdu_ui_utils.c | 2 +-
 ui/tap_export_pdu.c      | 3 +--
 ui/tap_export_pdu.h      | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)