Wireshark-commits: [Wireshark-commits] master e13d8be: CMake: Make sure we use the same minimum mac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Dec 2018 07:38:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e13d8be96284318b95ddafaecd6403a87f618c1c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e13d8be by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Make sure we use the same minimum macOS version everywhere.
    
    Add a MIN_MACOS_VERSION variable. Update it and sanity check it
    according to CMAKE_OSX_DEPLOYMENT_TARGET and our Qt version. Use it to
    set our minimum macOS version in various places.
    
    Change-Id: Icaf0dbe463f34d182986868021e2b56d2239da38
    Reviewed-on: https://code.wireshark.org/review/31048
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b22da8b   IMAP: Reassemble message elements and add request/response tracking
     add  e13d8be   CMake: Make sure we use the same minimum macOS version everywhere.


Summary of changes:
 CMakeLists.txt                                     | 41 ++++++-----
 packaging/macosx/Info.plist.in                     |  2 +-
 .../{Read_me_first.rtf => Read_me_first.rtf.in}    | 79 +++++++++++-----------
 packaging/macosx/osx-dmg.sh.in                     |  4 +-
 4 files changed, 66 insertions(+), 60 deletions(-)
 rename packaging/macosx/{Read_me_first.rtf => Read_me_first.rtf.in} (70%)