Wireshark · Wireshark-commits: [Wireshark-commits] master 98e7495: Added multiple new field dissectors for the BACnet-APDU protocol

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=98e74957b02f58b9bc1b6f0bc200cb3f39c5de16
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

98e7495 by Jonathan Fleming (jonathan@xxxxxxxxxx):

    Added multiple new field dissectors for the BACnet-APDU protocol.
    
    Replaced global vars with fPresentValue and wrapper functions.
    Split bacapp.present_value dissector based on datatype for filtering.
    Replaced char array buffers with wmem api calls.
    Rebased commit onto latest master branch.
    Removed date and time present_value field dissectors.
    
    dissectors added:
    	bacapp.object_name
    	bacapp.to_state
    	bacapp.from_state
    	bacapp.notify_type
    	bacapp.error_code
    	bacapp.error_class
    	bacapp.event_type
    
    present_value dissectors added:
    	bacapp.present_value.null
    	bacapp.present_value.boolean
    	bacapp.present_value.uint
    	bacapp.present_value.int
    	bacapp.present_value.real
    	bacapp.present_value.octet_string
    	bacapp.present_value.char_string
    	bacapp.present_value.bit_string
    	bacapp.present_value.enum_index
    
    Change-Id: I3ba9327ee22787da59190204e808f8c10dc8fabd
    Reviewed-on: https://code.wireshark.org/review/30847
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5bf37f6   text2pcap: allow to set interface name
     add  98e7495   Added multiple new field dissectors for the BACnet-APDU protocol.


Summary of changes:
 epan/dissectors/packet-bacapp.c | 618 ++++++++++++++++++++++++++++++++++++----
 epan/dissectors/packet-bacapp.h |  16 ++
 2 files changed, 581 insertions(+), 53 deletions(-)