Wireshark-commits: [Wireshark-commits] master 43dfd45: Move more version-info-related stuff to vers
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 13 Dec 2018 03:16:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43dfd45faa8af0b239a671b25ab6a398fa32f5c6
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

43dfd45 by Guy Harris (guy@xxxxxxxxxxxx):

    Move more version-info-related stuff to version_info.c.
    
    Have a ws_init_version_info() routine that, given an application name
    string:
    
    	constructs the app-name-and-version-information string, and
    	saves it;
    
    	adds the initial crash information on platforms that support it,
    	and saves it.
    
    Have show_version() use the saved information and take no arguments.
    
    Add a show_help_header() routine to print the header for --help
    command-line options, given a description of the application; it prints
    the application name and version information, the description, and the
    "See {wireshark.org URL}" line.
    
    Use those routines in various places, including providing the
    "application name" string in pcapng SHBs.
    
    Change-Id: I0042a8fcc91aa919ad5c381a8b8674a007ce66df
    Reviewed-on: https://code.wireshark.org/review/31029
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a34cc98   Put the main() and wmain() routines for CLI programs into a separate file.
     add  43dfd45   Move more version-info-related stuff to version_info.c.


Summary of changes:
 capinfos.c                     | 31 +++-------------
 captype.c                      | 31 +++-------------
 dumpcap.c                      | 36 ++++---------------
 editcap.c                      | 37 +++----------------
 fuzz/fuzzshark.c               | 23 ++----------
 mergecap.c                     | 41 +++++----------------
 rawshark.c                     | 29 ++++-----------
 reordercap.c                   | 31 +++-------------
 sharkd.c                       | 22 +++---------
 text2pcap.c                    | 36 +++----------------
 tfshark.c                      | 35 ++++--------------
 tshark.c                       | 39 +++++---------------
 ui/commandline.c               | 10 ++----
 ui/commandline.h               |  3 +-
 ui/qt/main.cpp                 | 22 ++----------
 ui/tap_export_pdu.c            |  2 +-
 version_info.c                 | 81 ++++++++++++++++++++++++++++++++++--------
 version_info.h                 | 51 ++++++++++++++++++++++++--
 wiretap/nettrace_3gpp_32_423.c |  2 +-
 19 files changed, 188 insertions(+), 374 deletions(-)