Wireshark-commits: [Wireshark-commits] master 3757db3: ENIP: Add more error checking
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Dec 2018 04:41:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3757db3148877a1c2c8d29a33a6f78ebc2331fe7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3757db3 by Dylan Ulis (daulis0@xxxxxxxxx):

    ENIP: Add more error checking
    
    1. Added a check that the Common Packet Format Item Length < remaining
      data for that layer.
    2. Added a check that there should always be at least 4 bytes available
      for each Common Packet Format item (Type ID + Length)
    
    Change-Id: Ie6f2b7904d52d8699c06cfef6844cf0032293d97
    Reviewed-on: https://code.wireshark.org/review/31002
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  14dc9a3   CIP Safety: Minor additions
     add  3757db3   ENIP: Add more error checking


Summary of changes:
 epan/dissectors/packet-enip.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)