Wireshark-commits: [Wireshark-commits] master 5762fc6: CIP: Improve connected data information
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5762fc617ab0f292d2905d0dccf3c6c7b7e8c018
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
5762fc6 by Dylan Ulis (daulis0@xxxxxxxxx):
CIP: Improve connected data information
1. For each connected data message, display generated connection
information including:
a. Connection Path from the initial connection
b. API values
c. Forward Open packet number. (This already existed, but moving it to a
consistent place in the tree)
2. Display O->T or T->O in the Info column depending on the direction of data.
3. Remove cip.conn_path_class filter. This was originally added to show
which type of data is in a given packet. But, it's not really needed
anymore because we have the generated connection path in each connected
data packet now.
4. Ensure dummy structs used for Decode As menus are zeroed out.
5. memset -> zero initialization
pcaps from the following bug reports are good examples:
Bug: 14939
Bug: 6617
Bug: 14916
Bug: 14958
Change-Id: I63885a5ca41f95e04f855a1e1dcd9ab3684f7eec
Reviewed-on: https://code.wireshark.org/review/30808
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 98f5470 packet-nfs.c: Bugfix NFSv4 ACCESS reply
add 5762fc6 CIP: Improve connected data information
Summary of changes:
epan/dissectors/packet-cip.c | 30 +++----
epan/dissectors/packet-cip.h | 5 ++
epan/dissectors/packet-cipmotion.c | 2 +-
epan/dissectors/packet-cipsafety.c | 11 ++-
epan/dissectors/packet-enip.c | 160 +++++++++++++++++++++++++------------
epan/dissectors/packet-enip.h | 5 ++
6 files changed, 136 insertions(+), 77 deletions(-)
