Wireshark-commits: [Wireshark-commits] master ac4c11f: cattp: use the version bits in the heristic
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 08 Dec 2018 16:35:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac4c11f26eb5544788d08c918252da6c4b1b0b43
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ac4c11f by Martin Kaiser (wireshark@xxxxxxxxx):

    cattp: use the version bits in the heristic check
    
    The CAT-TP specification says explicitly that the version bits must be
    zero. Fail the heuristic check if they aren't.
    
    I checked ETSI TS 102 127 V15.0.0 from
    https://www.etsi.org/deliver/etsi_ts/102100_102199/102127/15.00.00_60/ts_102127v150000p.pdf
    
    Bug: 15342
    Change-Id: I05a886ccd5811f367abdb9faead4983d137c12c6
    Reviewed-on: https://code.wireshark.org/review/30970
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  a02d592   Remove some unused images.
     add  ac4c11f   cattp: use the version bits in the heristic check


Summary of changes:
 epan/dissectors/packet-cattp.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)