Wireshark-commits: [Wireshark-commits] master 08a2a4d: DOCSIS: better decoding for unknown tlvs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Dec 2018 14:55:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08a2a4d47362dce427533055a793a46a6358f157
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

08a2a4d by Bruno Verstuyft (bruno.verstuyft@xxxxxxxxxxxx):

    DOCSIS: better decoding for unknown tlvs
    
    Previous decoding showed "Unknown TLV: <TLV value>". This was confusing, because people interpreted the value as the type of the unknown TLV.
    
    Change-Id: Ia9259db547fca393c248f78ea7c758969b69548e
    Reviewed-on: https://code.wireshark.org/review/30959
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f618fcd   dof: remove unnecessary uat_load calls
     add  08a2a4d   DOCSIS: better decoding for unknown tlvs


Summary of changes:
 epan/dissectors/packet-docsis-tlv.c | 141 ++++++++++++++++++++++++------------
 1 file changed, 95 insertions(+), 46 deletions(-)