Wireshark-commits: [Wireshark-commits] master-2.6 ba4bf35: Update comments, get rid of IMPORT_MAX_P
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 06 Dec 2018 18:44:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba4bf35f0d82d597e69cb312dd724ccaba39d3e0
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

ba4bf35 by Guy Harris (guy@xxxxxxxxxxxx):

    Update comments, get rid of IMPORT_MAX_PACKET.
    
    Get rid of the IMPORT_MAX_PACKET #define; just directly use
    WTAP_MAX_PACKET_SIZE_STANDARD, to match what text2pcap.c does.
    
    Update comments in text2pcap.c and ui/text_import.c to say the maximum
    packet size is WTAP_MAX_PACKET_SIZE_STANDARD.
    
    Change-Id: I34118f76426d1416fccf43b2a356ad8d200de19b
    Ping-Bug: 15292
    Reviewed-on: https://code.wireshark.org/review/30945
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (backported from commit 0946518780bc260d0668485b3f6f7e1d14325a7b)
    Reviewed-on: https://code.wireshark.org/review/30946
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    

Actions performed:

    from  e25b092   Qt: Fix tooltip on import size
     add  ba4bf35   Update comments, get rid of IMPORT_MAX_PACKET.


Summary of changes:
 text2pcap.c                  | 5 +++--
 ui/gtk/file_import_dlg.c     | 4 ++--
 ui/qt/import_text_dialog.cpp | 4 ++--
 ui/text_import.c             | 9 +++++----
 ui/text_import.h             | 2 --
 5 files changed, 12 insertions(+), 12 deletions(-)