Wireshark · Wireshark-commits: [Wireshark-commits] master 453e722: krb5: do not dissect PA-S4U-X509-USER inside encrypted-pa-data

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=453e72299c9d18b5e2adaea90e62e96e16b1cac6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

453e722 by Isaac Boukris (iboukris@xxxxxxxxx):

    krb5: do not dissect PA-S4U-X509-USER inside encrypted-pa-data
    
    According to MS-SFU 2.2.2 PA_S4U_X509_USER checksum section;
    PA-S4U-X509-USER may be returned inside encrypted-pa-data, but
    it contains just the checksum data so do not try to dissect it.
    
    Quote:
    The padata of type 130 in the encrypted-pa-data field contains
    the checksum value in the S4U request concatenated with the
    checksum value in the S4U reply.
    
    Change-Id: Ia124f56914ef2fefd5b0a64fccd176911321f246
    Signed-off-by: Isaac Boukris <iboukris@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30908
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9cba325   couchbase: Update for recent collection changes
     add  453e722   krb5: do not dissect PA-S4U-X509-USER inside encrypted-pa-data


Summary of changes:
 epan/dissectors/asn1/kerberos/kerberos.cnf         | 13 +++-
 .../asn1/kerberos/packet-kerberos-template.c       |  1 +
 epan/dissectors/packet-kerberos.c                  | 89 ++++++++++++++--------
 3 files changed, 69 insertions(+), 34 deletions(-)