Wireshark-commits: [Wireshark-commits] master 1bd99df: CDMA2000: Improper offset handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 03 Dec 2018 17:02:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1bd99df3535ac053f182a7e4e2246dae3e4c53ed
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1bd99df by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    CDMA2000: Improper offset handling
    
    Somewhere in the code the handling of the offset goes wrong.
    Instead of incrementing the offset it's the pointer to the offset
    which is being incremented, leading to all sorts of problems.
    Add a dereference to these few statements which lack them.
    
    Bug: 15322
    Change-Id: If575711a5b120f25f0172e0efb26e01f07244e8b
    Signed-off-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30899
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  228da02   RTP: Restructure call id handling.
     add  1bd99df   CDMA2000: Improper offset handling


Summary of changes:
 epan/dissectors/packet-cdma2k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)