Wireshark-commits: [Wireshark-commits] master 3d7a2a7: Fix AODV flags dissection for version draft_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 Nov 2018 13:50:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d7a2a711b16fe42b1298f35ae18048d587c380a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3d7a2a7 by Christophe GUERBER (christophe.guerber@xxxxxxxxx):

    Fix AODV flags dissection for version draft_01_v6
    
    Apply change 30835 to dissector functions for version draft_01_v6 of the
    protocol.
    
    Dissector code added flag values in the "branch" label. Individual flags
    are '0' when expanding the branch in the packet details pane due to
    wrong definition.
    
    Values on the branch label should be added by proto_tree_add_bitmask.
    Use proto_tree_add_bitmask_with_flags instead. Remove code that adds
    flag values to label "by hand" and remove unused local vars.
    
    Change-Id: I1f639e4b0e617834276f2e11283315ac8b1594f1
    Reviewed-on: https://code.wireshark.org/review/30843
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6e8ff29   win32: adjust some names in the Npcap installation page
     add  3d7a2a7   Fix AODV flags dissection for version draft_01_v6


Summary of changes:
 epan/dissectors/packet-aodv.c | 41 +++++++++--------------------------------
 1 file changed, 9 insertions(+), 32 deletions(-)