Wireshark · Wireshark-commits: [Wireshark-commits] master ee61bc7: test: use assertRun instead of runProcess where possible

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee61bc739e133ca2b07bc51d1baa3249265193dd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ee61bc7 by Peter Wu (peter@xxxxxxxxxxxxx):

    test: use assertRun instead of runProcess where possible
    
    The case_decrypt_tls.test_tls_rsa_pq test is unexpectedly passing when
    GnuTLS is disabled. It checks for '/' in the output, but that also
    matches an error message. Use assertRun here and pretty much everywhere
    else to catch such issues. Remove a few redundant returncode checks.
    
    Change-Id: I0f9d1dadc0ca73eef9cffb3e2f452aa7c8395c95
    Reviewed-on: https://code.wireshark.org/review/30838
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9c0beaf   Fixes AODV packet dissector for flags in RREQ, RREP and RERR
     add  ee61bc7   test: use assertRun instead of runProcess where possible


Summary of changes:
 test/suite_capture.py     | 57 ++++++++---------------------
 test/suite_clopts.py      |  4 +--
 test/suite_decryption.py  | 92 +++++++++++++++++++++++------------------------
 test/suite_dissection.py  |  8 ++---
 test/suite_fileformats.py | 26 +++++++-------
 test/suite_follow.py      |  2 +-
 test/suite_io.py          | 18 ++++------
 test/suite_mergecap.py    | 30 ++++++++--------
 test/suite_nameres.py     |  6 ++--
 9 files changed, 104 insertions(+), 139 deletions(-)