Wireshark-commits: [Wireshark-commits] master f4194b1: CMake: Change some install() paths to match
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Nov 2018 03:19:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4194b128fbf204759602295a1e09d181f91c39f
Submitter: "João Valverde <j@xxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f4194b1 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: Change some install() paths to match NSIS package
    
    Currently our Windows code looks for data files in the same
    folder as the binary executable (presumably to make the
    application relocatable, although it should be possible
    to improve this with relative paths?).
    
    Ping-Bug: 15301
    Change-Id: I0fef4e87dc9d1d8edef81dd11755761fddd0fd12
    Reviewed-on: https://code.wireshark.org/review/30819
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  a062ab8   CMake: Enable install target on Windows (missing DLLs)
     add  f4194b1   CMake: Change some install() paths to match NSIS package


Summary of changes:
 CMakeLists.txt            | 37 +++++++++++++++++++++++++++++--------
 epan/wslua/CMakeLists.txt |  8 +++++++-
 2 files changed, 36 insertions(+), 9 deletions(-)