Wireshark-commits: [Wireshark-commits] master 1f3b7d1: packet-icmp.c: Add some unused fields and fi
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Nov 2018 07:18:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f3b7d15693870b4d3d0e3a1211d087b8e6ec8ae
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1f3b7d1 by Joerg Mayer (jmayer@xxxxxxxxx):

    packet-icmp.c: Add some unused fields and fix a logic error
    
    - Adding rfc4884 support failed to properly add the unused fields if
      no length field was present.
    - The was a logic error when both length and MTU size were present.
    - reformat the lines in that section to no longer adhere to 80 columns
    
    Change-Id: I3bcca25cc7d5e866a040c5c6a8011144ebc3370e
    Reviewed-on: https://code.wireshark.org/review/30781
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e111cc9   Set direction correctly for Bluetooth H1 packets
     add  1f3b7d1   packet-icmp.c: Add some unused fields and fix a logic error


Summary of changes:
 epan/dissectors/packet-icmp.c | 119 ++++++++++++++++--------------------------
 1 file changed, 46 insertions(+), 73 deletions(-)