Wireshark-commits: [Wireshark-commits] master 47cd8c7: text2pcap: cleanup type usage
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Nov 2018 22:17:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47cd8c7e8ed5dcbe02f2dbf911b2125320c0347b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

47cd8c7 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    text2pcap: cleanup type usage
    
    The glib gboolean and integer types are used interchangably,
    while a proper use is easily achievable.
    
    While at it, replace the duplicate definition of the IPv4 source
    and destination addresses (endian sensitive).
    
    Change-Id: I5378544f370dc41962eb6303ddeeecb184db14f4
    Signed-off-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30770
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  af987ec   TFTP: Improve dissection of ERROR packets.
     add  47cd8c7   text2pcap: cleanup type usage


Summary of changes:
 text2pcap.c | 30 ++++++++++++------------------
 1 file changed, 12 insertions(+), 18 deletions(-)