Wireshark · Wireshark-commits: [Wireshark-commits] master 7943dbf: test: extend sharkd tests to cover all requests

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7943dbf7bbffb535f83c333b779f9d384c7fe6df
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7943dbf by Peter Wu (peter@xxxxxxxxxxxxx):

    test: extend sharkd tests to cover all requests
    
    All request types have a corresponding test_sharkd_req_* test names
    which tests the current (documented) behavior. The frame and download
    tests are not very comprehensive though, but it's better than nothing.
    
    (The original test_sharkd_hello_dhcp_pcap test is replaced by
    test_sharkd_req_status and test_sharkd_req_frames, although the latter
    does not literally check for the "DHCP" column anymore.)
    
    Change-Id: Ic39b954fc50065345ac46e96a7057b7aba2a09e3
    Reviewed-on: https://code.wireshark.org/review/30743
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  049d746   sharkd: update documentation for some requests to match reality
     add  7943dbf   test: extend sharkd tests to cover all requests


Summary of changes:
 test/matchers.py     |  67 ++++++++
 test/suite_sharkd.py | 467 ++++++++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 492 insertions(+), 42 deletions(-)
 create mode 100644 test/matchers.py