Wireshark-commits: [Wireshark-commits] master-2.6 2e58e04: LISP: Switch to proto_tree_add_subtree_f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Nov 2018 19:20:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e58e04e3ade5079a4542ebb39d15bef3c23b89b
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

2e58e04 by Lorand Jakab (ljakab@xxxxxxxxxx):

    LISP: Switch to proto_tree_add_subtree_format()
    
    When the LISP dissector was initially written, it followed a different
    pattern for adding subtrees with a text label, which needs to be
    modified while dissecting: proto_tree_add_item() +
    proto_item_append_text() + proto_item_add_subtree().
    
    This commit updates the code to use the more elegant
    proto_tree_add_subtree_format() call.
    
    Change-Id: Icb6424be3c9cdecbfe9bb5aa2d39f3ad3d1499e0
    Signed-off-by: Lorand Jakab <ljakab@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30655
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30702
    

Actions performed:

    from  068e8d5   SSL: Send the record_length to the dissect_ssl3_alert and use it
     add  2e58e04   LISP: Switch to proto_tree_add_subtree_format()


Summary of changes:
 epan/dissectors/packet-lisp.c | 35 ++++++-----------------------------
 1 file changed, 6 insertions(+), 29 deletions(-)