Wireshark · Wireshark-commits: [Wireshark-commits] master f8100ba: LISP: Switch to proto_tree_add_subtree_format()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8100ba30a581836e86c11e5fbf50d5f4d0cca83
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f8100ba by Lorand Jakab (ljakab@xxxxxxxxxx):

    LISP: Switch to proto_tree_add_subtree_format()
    
    When the LISP dissector was initially written, it followed a different
    pattern for adding subtrees with a text label, which needs to be
    modified while dissecting: proto_tree_add_item() +
    proto_item_append_text() + proto_item_add_subtree().
    
    This commit updates the code to use the more elegant
    proto_tree_add_subtree_format() call.
    
    Change-Id: Icb6424be3c9cdecbfe9bb5aa2d39f3ad3d1499e0
    Signed-off-by: Lorand Jakab <ljakab@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30655
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  e2e069e   travis: enable tests even if libpcap is disabled
     add  f8100ba   LISP: Switch to proto_tree_add_subtree_format()


Summary of changes:
 epan/dissectors/packet-lisp-tcp.c |  9 +--------
 epan/dissectors/packet-lisp.c     | 35 ++++++-----------------------------
 2 files changed, 7 insertions(+), 37 deletions(-)