Wireshark-commits: [Wireshark-commits] master cb9be38: tshark: do not print packet information when
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Nov 2018 13:54:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb9be3850da46ca1f706a00b16cdb65a95ce66a0
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cb9be38 by Peter Wu (peter@xxxxxxxxxxxxx):

    tshark: do not print packet information when using -w without libpcap
    
    The test_tshark_io_direct_stdout test was failing because the command
    "tshark -r test/captures/dhcp.pcap -w - > some.pcap" produced a corrupt
    capture file which has the packet information appended at the end.
    
    Change-Id: I1a79e98f1475c29d7dad3ff90d4cb689f46b0e57
    Fixes: 57389a0c69 ("make tshark compile and work also when pcap is not available")
    Reviewed-on: https://code.wireshark.org/review/30668
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a3239ad   Qt: fix build with Qt 5.4 and older
     add  cb9be38   tshark: do not print packet information when using -w without libpcap


Summary of changes:
 tshark.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)