Wireshark-commits: [Wireshark-commits] master a1372f6: Use an enum for compression types in various
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1372f6d017cb9798dce7de5e25d329c82a2da79
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
a1372f6 by Guy Harris (guy@xxxxxxxxxxxx):
Use an enum for compression types in various interfaces.
This:
1) means that we don't have to flag the compression argument with a
comment to indicate what it means (FALSE doesn't obviously say "not
compressed", WTAP_UNCOMPRESSED does);
2) leaves space in the interfaces in question for additional compression
types.
(No, this is not part 1 of an implementation of additional compression
types, it's just an API cleanup. Implementing additional compression
types involves significant work in libwiretap, as well as UI changes to
replace "compress the file" checkboxes with something to indicate *how*
to compress the file, or to always use some other form of compression).
Change-Id: I1d23dc720be10158e6b34f97baa247ba8a537abf
Reviewed-on: https://code.wireshark.org/review/30660
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from e12753d TDS: Fix decoding of TDS7 password.
add a1372f6 Use an enum for compression types in various interfaces.
Summary of changes:
capinfos.c | 74 ++++++++++----------
cfile.h | 112 +++++++++++++++----------------
debian/libwiretap0.symbols | 2 +-
editcap.c | 6 +-
epan/dissectors/packet-snort.c | 2 +-
epan/wslua/wslua_capture_info.c | 4 +-
epan/wslua/wslua_dumper.c | 4 +-
epan/wslua/wslua_file.c | 2 +-
extcap/androiddump.c | 2 +-
file.c | 26 +++----
file.h | 9 +--
randpkt_core/randpkt_core.c | 6 +-
reordercap.c | 4 +-
tshark.c | 8 +--
ui/qt/capture_file_dialog.cpp | 19 +++---
ui/qt/capture_file_dialog.h | 4 +-
ui/qt/capture_file_properties_dialog.cpp | 2 +-
ui/qt/gsm_map_summary_dialog.cpp | 2 +-
ui/qt/import_text_dialog.cpp | 2 +-
ui/qt/main_window.cpp | 22 +++---
ui/qt/main_window.h | 2 +-
ui/qt/mtp3_summary_dialog.cpp | 2 +-
ui/summary.c | 2 +-
ui/summary.h | 70 +++++++++----------
ui/tap_export_pdu.c | 4 +-
ui/win32/file_dlg_win32.c | 13 ++--
ui/win32/file_dlg_win32.h | 8 +--
wiretap/file_access.c | 70 +++++++++++--------
wiretap/merge.c | 8 +--
wiretap/nettrace_3gpp_32_423.c | 3 +-
wiretap/wtap-int.h | 2 +-
wiretap/wtap.c | 9 ++-
wiretap/wtap.h | 29 +++++---
33 files changed, 281 insertions(+), 253 deletions(-)
