Wireshark-commits: [Wireshark-commits] master ad2bc77: Just pass on a snapshot length of 0 to the d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Nov 2018 23:25:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad2bc773d6c777290b2485de8a43350682c438a1
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ad2bc77 by Guy Harris (guy@xxxxxxxxxxxx):

    Just pass on a snapshot length of 0 to the dumper.
    
    It means "snapshot length unknown".
    
    For most file formats, the snapshot length isn't recorded (even for
    formats that support slicing - all they record is the on-the-network
    length, and length after slicing, for each packet), so it's ignored in
    the dumper.
    
    The one exception is pcap, which records it in the file header; if it's
    unknown, the pcap-writing code picks the maximum supported snapshot
    length for the file's link-layer header type.
    
    Change-Id: Ieda5dfe34c4bac63e43fdadeff31799ac3c908de
    Reviewed-on: https://code.wireshark.org/review/30657
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d631c17   test: convert suite_dfilter to use fixtures
     add  ad2bc77   Just pass on a snapshot length of 0 to the dumper.


Summary of changes:
 tshark.c | 6 ------
 1 file changed, 6 deletions(-)