Wireshark-commits: [Wireshark-commits] master-2.6 bb43bd9: ui: add missing break.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Nov 2018 09:31:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb43bd9be7d6335df2a9a49d21e97d41a481ec2b
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

bb43bd9 by Dario Lombardo (lomato@xxxxxxxxx):

    ui: add missing break.
    
    Error:
    ../ui/alert_box.c: In function ‘cfile_write_failure_alert_box’:
    ../ui/alert_box.c:359:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
                 simple_error_message_box(
                 ^~~~~~~~~~~~~~~~~~~~~~~~~
                             "Frame %u%s has a network type that differs from the network type of earlier packets, which isn't supported in a \"%s\" file.",
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                             framenum, in_file_string,
                             ~~~~~~~~~~~~~~~~~~~~~~~~~
                             wtap_file_type_subtype_string(file_type_subtype));
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../ui/alert_box.c:364:9: note: here
             case WTAP_ERR_PACKET_TOO_LARGE:
             ^~~~
    
    Change-Id: I55464afff5625ae8c587470e417234560c7e606c
    Reviewed-on: https://code.wireshark.org/review/30623
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 8a2741010a057df88c3039f15d9823570f433cf8)
    Reviewed-on: https://code.wireshark.org/review/30624
    

Actions performed:

    from  611d7c8   Catch attempts to write multiple encapsulation types if unsupported.
     add  bb43bd9   ui: add missing break.


Summary of changes:
 ui/alert_box.c | 1 +
 1 file changed, 1 insertion(+)