Wireshark-commits: [Wireshark-commits] master 684d4c1: PKCS10: Enabling own dissection function for
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Nov 2018 07:48:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=684d4c11a2816f7868aba4a8f57744adb9988705
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

684d4c1 by Martin Peylo (wireshark@xxxxxxx):

    PKCS10: Enabling own dissection function for Attributes
    
    The one in pkix1explicit might be broken, while it might have unexpected
    side-effects to mess with that.  Anyway, RFC 2986 defines the Attribute
    sequence for PKCS10 directly.
    
    Change-Id: I854b5b5fb83322a1302d011c9cd6f2d5c9fc2b78
    Reviewed-on: https://code.wireshark.org/review/30585
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8cd89b3   Fix function name in comment.
     add  684d4c1   PKCS10: Enabling own dissection function for Attributes


Summary of changes:
 epan/dissectors/asn1/pkcs10/PKCS10.asn | 10 +++--
 epan/dissectors/asn1/pkcs10/pkcs10.cnf |  6 +++
 epan/dissectors/packet-pkcs10.c        | 70 +++++++++++++++++++++++++++++++++-
 3 files changed, 82 insertions(+), 4 deletions(-)