Wireshark-commits: [Wireshark-commits] master b041883: NTP: fix dissection of authentication parame
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 07 Nov 2018 08:42:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b041883e2722f265a3cda6a477730704ed0bf225
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b041883 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NTP: fix dissection of authentication parameters in mode 7 packets
    
    Based on ntp_request.h header file:
    - authentication parameters are only present in request messages, not
    resonse ones
    - the authentication timestamp is at a fixed position with an offset
    of 184 bytes in the packet, followed by the encryption keyid and
    optionally the mac
    - do not display the authentication timestamp (even if present in the
    packet) if the authentication bit is not set (as the value 0 translates
    into a date in 2036)
    
    Bug: 15258
    Change-Id: Id2e49beeef4a0fdc3082d9b7b09a214fd531a6bb
    Reviewed-on: https://code.wireshark.org/review/30527
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  a655919   DNS: fix compilation broken by g224aa2ed98
     add  b041883   NTP: fix dissection of authentication parameters in mode 7 packets


Summary of changes:
 epan/dissectors/packet-ntp.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)