Wireshark-commits: [Wireshark-commits] master 779003b: extcap: add check before using pipedata.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Nov 2018 14:49:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=779003b6a9cac281805fbcbf3ec76ec0d0d2e30b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

779003b by Dario Lombardo (lomato@xxxxxxxxx):

    extcap: add check before using pipedata.
    
    In line 1131 the check assumes that pipedata can be NULL. All subsequent
    uses require it is not NULL, otherwise it may result in a NULL
    dereference.
    
    Found by Clang.
    
    Change-Id: I9bd35b6213adfb41de2e96d5cc6da2b3bac4dd95
    Reviewed-on: https://code.wireshark.org/review/30478
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8e4552a   isakmp: free the ikev[12] uat tables on shutdown
     add  779003b   extcap: add check before using pipedata.


Summary of changes:
 extcap.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)